feat!: bump bignum to v0.5.0
#30
Merged
+76
−49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Savio-Sou
assigned TomAFrench, kashbrti and jtriley-eth and unassigned TomAFrench, kashbrti and jtriley-eth
|
@kashbrti this is actually ready for review now. |
kashbrti
reviewed
Jan 16, 2025
| @@ -456,7 +458,7 @@ unconstrained fn compute_and_print_offset_generators<Fq, Curve, let K: u32, let | |||
| cofactor: Field, | |||
| ) | |||
| where | |||
| Fq: BigNumTrait + std::ops::Mul + std::ops::Add + std::cmp::Eq, | |||
There was a problem hiding this comment.
This change has happened in many places. wondering why we're not getting warnings about the std traits not being in scope?
There was a problem hiding this comment.
We're using the fully qualified name for these traits here so there's no need to import them.
kashbrti
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Resolves #29
Summary*
This PR updates to the latest release of noir-bignum
Additional Context
PR Checklist*
cargo fmton default settings.